Skip to content

feat: Refactor html extractor to two stages#521

Merged
drunkpig merged 19 commits intoccprocessor:devfrom
e06084:dev
Aug 20, 2025
Merged

feat: Refactor html extractor to two stages#521
drunkpig merged 19 commits intoccprocessor:devfrom
e06084:dev

Conversation

@e06084
Copy link
Copy Markdown
Collaborator

@e06084 e06084 commented Aug 14, 2025

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

html抽取拆为2个阶段:

image

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 89.13043% with 20 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
llm_web_kit/simple.py 82.81% 11 Missing ⚠️
llm_web_kit/exception/exception.py 73.33% 4 Missing ⚠️
llm_web_kit/extractor/html/main_html_parser.py 97.14% 2 Missing ⚠️
llm_web_kit/extractor/html/pre_extractor.py 81.81% 2 Missing ⚠️
llm_web_kit/extractor/html/extractor.py 83.33% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #521      +/-   ##
==========================================
- Coverage   90.96%   90.92%   -0.05%     
==========================================
  Files         102      103       +1     
  Lines        8866     8965      +99     
==========================================
+ Hits         8065     8151      +86     
- Misses        801      814      +13     
Files with missing lines Coverage Δ
llm_web_kit/extractor/extractor_chain.py 98.88% <100.00%> (+0.13%) ⬆️
llm_web_kit/input/datajson.py 84.77% <100.00%> (+0.07%) ⬆️
llm_web_kit/libs/html_utils.py 94.24% <100.00%> (ø)
llm_web_kit/tools/cli.py 90.47% <100.00%> (-0.64%) ⬇️
llm_web_kit/extractor/html/extractor.py 92.25% <83.33%> (-1.30%) ⬇️
llm_web_kit/extractor/html/main_html_parser.py 97.14% <97.14%> (ø)
llm_web_kit/extractor/html/pre_extractor.py 94.39% <81.81%> (-0.92%) ⬇️
llm_web_kit/exception/exception.py 82.18% <73.33%> (-0.44%) ⬇️
llm_web_kit/simple.py 85.33% <82.81%> (-11.50%) ⬇️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread llm_web_kit/extractor/html/main_html_parser.py Outdated
Comment thread llm_web_kit/simple.py Outdated
Comment thread llm_web_kit/extractor/html/main_html_parser.py Outdated
Comment thread llm_web_kit/simple.py Outdated
Comment thread llm_web_kit/simple.py Outdated
Comment thread llm_web_kit/simple.py Outdated
@e06084 e06084 requested a review from drunkpig August 18, 2025 11:03
@drunkpig drunkpig merged commit d91b351 into ccprocessor:dev Aug 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants